Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handled NPE in the AuthenticationActivity #759

Merged
merged 5 commits into from
Sep 17, 2024
Merged

Handled NPE in the AuthenticationActivity #759

merged 5 commits into from
Sep 17, 2024

Conversation

pmathew92
Copy link
Contributor

@pmathew92 pmathew92 commented Sep 5, 2024

Changes

This PR tries to handle the issue raised in #749 . In the scenario where authorization uri or custom tabs becomes null in the bundle, it will thrown an Authentication exception

Testing

  • This change adds unit test coverage

  • This change adds integration test coverage

  • This change has been tested on the latest version of the platform/language or why not

Checklist

Copy link
Contributor

@desusai7 desusai7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pmathew92 pmathew92 changed the title Fixed issue #749 Handled NPE in the AuthenticationActivity Sep 16, 2024
@pmathew92 pmathew92 requested a review from a team as a code owner September 16, 2024 10:48
@pmathew92 pmathew92 merged commit 59fad7e into main Sep 17, 2024
10 checks passed
@pmathew92 pmathew92 deleted the fix/SDK-4968 branch September 17, 2024 04:56
@pmathew92 pmathew92 mentioned this pull request Oct 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants